Skip to content

First proj #47689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

First proj #47689

wants to merge 3 commits into from

Conversation

GivyBoy
Copy link
Contributor

@GivyBoy GivyBoy commented Jul 12, 2022

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@pep8speaks
Copy link

Hello @GivyBoy! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 8336:57: W291 trailing whitespace
Line 8337:42: W291 trailing whitespace
Line 8338:61: W291 trailing whitespace
Line 8342:63: W291 trailing whitespace
Line 8343:58: W291 trailing whitespace

@mroeschke
Copy link
Member

Seems like you are working on #47690 instead, so closing. Next time please just update the same pull request with the latest changes

@mroeschke mroeschke closed this Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants