Skip to content

Add test for unique aggregation returning different dtypes #47603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 26, 2022
Merged

Add test for unique aggregation returning different dtypes #47603

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0097f75
TST: Added test for consistent type with unique agg #22558
KingOfTheShow69 Jul 5, 2022
1d695b1
Merge remote-tracking branch 'upstream/main' into unique-test
KingOfTheShow69 Jul 5, 2022
06db464
TST: Added test for consistent type with unique agg #22558
KingOfTheShow69 Jul 5, 2022
f977a15
TST: Moved and restructured test #22558
KingOfTheShow69 Jul 6, 2022
84f075d
TST: Moved test to different file #22558
KingOfTheShow69 Jul 15, 2022
105c338
TST: Changed scalars to 1-element lists
KingOfTheShow69 Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pandas/tests/groupby/aggregate/test_aggregate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1438,3 +1438,15 @@ def test_agg_of_mode_list(test, constant):
expected = expected.set_index(0)

tm.assert_frame_equal(result, expected)


def test_unique_agg_type():
# GH#22558
df1 = DataFrame({"a": [1, 2, 3], "b": [1, 1, 1]})
df2 = DataFrame({"a": [2, 2, 2], "b": [1, 1, 1]})
aggregation = {"a": "unique", "b": "unique"}

agg1 = df1.agg(aggregation)
agg2 = df2.agg(aggregation)

tm.assert_class_equal(agg1, agg2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please define expected as a DataFrame and then use tm.assert_frame_equal. Also, this is not a groupby test, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, this shouldn't be in groupby. I've made the changes and moved it to a more appropriate file.