Add test for unique aggregation returning different dtypes #47603
Conversation
phofl
changed the title
| agg1 = df1.agg(aggregation) | ||
| agg2 = df2.agg(aggregation) | ||
|
|
||
| tm.assert_class_equal(agg1, agg2) |
There was a problem hiding this comment.
Please define expected as a DataFrame and then use tm.assert_frame_equal. Also, this is not a groupby test, right?
There was a problem hiding this comment.
You're right, this shouldn't be in groupby. I've made the changes and moved it to a more appropriate file.
| ({"a": [2, 2, 2], "b": [1, 1, 1]}, {"a": 2, "b": 1}), | ||
| ], | ||
| ) | ||
| def test_unique_agg_type_is_series(test, constant): |
There was a problem hiding this comment.
This is still in the wrong place. Please check the frame folder for example. We have specific aggregations tests where this belongs
There was a problem hiding this comment.
I see some aggregation tests for DataFrames in apply/test_frame_apply.py. Would that be an appropriate place for this test?
jreback
added
Testing
|
@phofl I've moved my test to a new file, is this a better place for it? |
| "test, constant", | ||
| [ | ||
| ({"a": [1, 2, 3], "b": [1, 1, 1]}, {"a": [1, 2, 3], "b": 1}), | ||
| ({"a": [2, 2, 2], "b": [1, 1, 1]}, {"a": 2, "b": 1}), |
There was a problem hiding this comment.
I think the scalars in constant should be contained in lists e.g.
# result of agg
First aggregation: <class 'pandas.core.series.Series'>
a [1, 2, 3]
b [1]
dtype: object
Second aggregation: <class 'pandas.core.series.Series'>
a [2]
b [1]
dtype: object
In [3]: Series(data={"a": [1, 2, 3], "b": 1}, index=["a", "b"], dtype="object")
Out[3]:
a 2
b 1
dtype: object
In [4]: constant = {"a": [1, 2, 3], "b": 1}
In [6]: Series(data=constant, index=["a", "b"], dtype="object")
Out[6]:
a [1, 2, 3]
b 1
dtype: object
There was a problem hiding this comment.
Sure, I can do that. Either way will work, but I think you are right that it is more accurate for it to be one-element lists rather than scalars.
|
Thanks @srotondo (CI failure unrelated) |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.