Skip to content

CI: Run all code checks even if one fails #47482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Jun 23, 2022

xref #47469 (comment)

Solution gleaned from: https://stackoverflow.com/a/58859404

Want to always() run all these steps If pandas was built correctly

Note: Cannot use continue-on-error because if a check fails the build will still pass which we don't want https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepscontinue-on-error=

@mroeschke mroeschke added the CI Continuous Integration label Jun 23, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jun 23, 2022
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I've understood the GHA docs, this looks good to me

@mroeschke mroeschke merged commit 878504d into pandas-dev:main Jun 23, 2022
@mroeschke mroeschke deleted the ci/code_checks_always branch June 23, 2022 16:51
@jonashaag
Copy link
Contributor

jonashaag commented Jun 23, 2022

If we have this does it make sense to split the steps into multiple jobs? And have one upstream job that builds pandas so that work isn't duplicated. We could use that upstream job for ASV and docs as well.

@mroeschke
Copy link
Member Author

+1 to have one build pandas job for all the checks that share the environment.yml dependencies. I am slightly partial to the current job grouping though. Is there a max number of jobs that can run in parallel across workflows? I couldn't immediately find it in the docs

@jonashaag
Copy link
Contributor

I monitored the load on the Pandas CI pipeline for the past 14 days (with the help of another GHA pipeline :)) and this is the quantiles

0.0: 0
5.0: 0
10.0: 0
15.0: 0
20.0: 0
25.0: 0
30.0: 0
35.0: 2
40.0: 2
45.0: 2
50.0: 3
55.0: 5
60.0: 5
65.0: 5
70.0: 7
75.0: 8
80.0: 10
85.0: 14
90.0: 20

Checked every 13 minutes. 65% of the time we have < 5 workflows running, for a maximum of 5 * 17 = 85 parallel jobs (we have 17 jobs in the Ubuntu workflow). So I'm not sure it's worth reducing the number of parallel jobs right now. We might want to optimize latency-to-first-valuable-feedback instead.

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants