Skip to content

Commit 878504d

Browse files
authored
CI: Run all code checks even if one fails (#47482)
1 parent 45f094d commit 878504d

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

.github/workflows/code-checks.yml

+8-6
Original file line numberDiff line numberDiff line change
@@ -65,37 +65,39 @@ jobs:
6565
id: build
6666
uses: ./.github/actions/build_pandas
6767

68+
# The following checks are independent of each other and should still be run if one fails
6869
- name: Check for no warnings when building single-page docs
6970
run: ci/code_checks.sh single-docs
70-
if: ${{ steps.build.outcome == 'success' }}
71+
if: ${{ steps.build.outcome == 'success' && always() }}
7172

7273
- name: Run checks on imported code
7374
run: ci/code_checks.sh code
74-
if: ${{ steps.build.outcome == 'success' }}
75+
if: ${{ steps.build.outcome == 'success' && always() }}
7576

7677
- name: Run doctests
7778
run: ci/code_checks.sh doctests
78-
if: ${{ steps.build.outcome == 'success' }}
79+
if: ${{ steps.build.outcome == 'success' && always() }}
7980

8081
- name: Run docstring validation
8182
run: ci/code_checks.sh docstrings
82-
if: ${{ steps.build.outcome == 'success' }}
83+
if: ${{ steps.build.outcome == 'success' && always() }}
8384

8485
- name: Use existing environment for type checking
8586
run: |
8687
echo $PATH >> $GITHUB_PATH
8788
echo "PYTHONHOME=$PYTHONHOME" >> $GITHUB_ENV
8889
echo "PYTHONPATH=$PYTHONPATH" >> $GITHUB_ENV
90+
if: ${{ steps.build.outcome == 'success' && always() }}
8991

9092
- name: Typing
9193
uses: pre-commit/[email protected]
9294
with:
9395
extra_args: --hook-stage manual --all-files
94-
if: ${{ steps.build.outcome == 'success' }}
96+
if: ${{ steps.build.outcome == 'success' && always() }}
9597

9698
- name: Run docstring validation script tests
9799
run: pytest scripts
98-
if: ${{ steps.build.outcome == 'success' }}
100+
if: ${{ steps.build.outcome == 'success' && always() }}
99101

100102
asv-benchmarks:
101103
name: ASV Benchmarks

0 commit comments

Comments
 (0)