Skip to content

Revert "REF: remove JoinUnit.shape (#43651)" #47406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

This reverts commit bb9a985.

This is also included in #47372, but reverting this single commit separately will make it easier to backport the other PR, since this is the only commit that was not already included in 1.4, but was only done in 1.5 (cc @simonjayhawkins)

@simonjayhawkins simonjayhawkins added this to the 1.5 milestone Jun 17, 2022
@simonjayhawkins simonjayhawkins added Refactor Internal refactoring of code Internals Related to non-user accessible pandas implementation labels Jun 17, 2022
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jorisvandenbossche

@jbrockmendel ok to merge here?

@jbrockmendel
Copy link
Member

sure

@simonjayhawkins simonjayhawkins merged commit 3f72d8c into pandas-dev:main Jun 21, 2022
@jorisvandenbossche jorisvandenbossche deleted the revert-joinunit-shape branch June 22, 2022 12:18
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants