Skip to content

REF: remove JoinUnit.shape #43651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 7, 2022
Merged

REF: remove JoinUnit.shape #43651

merged 15 commits into from
Mar 7, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jorisvandenbossche
Copy link
Member

Can you please wait with further PRs to JoinUnit until the discussion in #43507 is resolved? (since those might make it harder to revert the change)

@jreback jreback added Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code labels Oct 3, 2021
@jreback
Copy link
Contributor

jreback commented Oct 3, 2021

Can you please wait with further PRs to JoinUnit until the discussion in #43507 is resolved? (since those might make it harder to revert the change)

@jorisvandenbossche if you don't like the new behavior then pls open an issue

@jreback jreback added this to the 1.4 milestone Oct 16, 2021
@jreback
Copy link
Contributor

jreback commented Oct 16, 2021

@jorisvandenbossche discussion is not happening. please open an issue if you disagree with current behavior.

@jorisvandenbossche
Copy link
Member

Can you respond to my comment at #43507 (comment)?

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Dec 12, 2021
@mroeschke mroeschke removed the Stale label Dec 27, 2021
@simonjayhawkins
Copy link
Member

simonjayhawkins commented Jan 5, 2022 •
edited
Loading

moving off 1.4

@simonjayhawkins simonjayhawkins removed this from the 1.4 milestone Jan 5, 2022
@jbrockmendel jbrockmendel added this to the 1.5 milestone Jan 6, 2022
@jreback
Copy link
Contributor

jreback commented Mar 6, 2022

@jbrockmendel pls rebase, let's just do this

@jreback jreback merged commit bb9a985 into pandas-dev:main Mar 7, 2022
@jbrockmendel jbrockmendel deleted the ref-concat-void-5 branch March 7, 2022 16:26
fabiangabel pushed a commit to fabiangabel/pandas that referenced this pull request Mar 8, 2022
@jbrockmendel @fabiangabel
REF: remove JoinUnit.shape (pandas-dev#43651)
46a2081
jorisvandenbossche added a commit to jorisvandenbossche/pandas that referenced this pull request Jun 15, 2022
@jorisvandenbossche
Revert "REF: remove JoinUnit.shape (pandas-dev#43651)"
90e966e 
This reverts commit bb9a985.
jorisvandenbossche added a commit to jorisvandenbossche/pandas that referenced this pull request Jun 17, 2022
@jorisvandenbossche
Revert "REF: remove JoinUnit.shape (pandas-dev#43651)"
57ae2a0 
This reverts commit bb9a985.
simonjayhawkins pushed a commit that referenced this pull request Jun 21, 2022
@jorisvandenbossche
Revert "REF: remove JoinUnit.shape (#43651)" (#47406)
3f72d8c 
This reverts commit bb9a985.
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jbrockmendel @yehoshuadimarsky
REF: remove JoinUnit.shape (pandas-dev#43651)
fee42e1
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jorisvandenbossche @yehoshuadimarsky
Revert "REF: remove JoinUnit.shape (pandas-dev#43651)" (pandas-dev#47406
581b0d9 
)

This reverts commit bb9a985.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@jbrockmendel @jorisvandenbossche @jreback @simonjayhawkins @mroeschke