Skip to content

Fix reading SAS7BDAT files with zero rows #47116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 31, 2022

Conversation

jonashaag
Copy link
Contributor

@mroeschke mroeschke added Bug IO SAS SAS: read_sas labels May 27, 2022
@mroeschke mroeschke added this to the 1.5 milestone May 27, 2022
@jreback
Copy link
Contributor

jreback commented May 27, 2022

cc @bashtage if you can look

@bashtage
Copy link
Contributor

Looks correct and good to me.

@mroeschke mroeschke merged commit d47eae8 into pandas-dev:main May 31, 2022
@mroeschke
Copy link
Member

Thanks @jonashaag

jonashaag added a commit to jonashaag/pandas that referenced this pull request Jun 9, 2022
* Fix reading SAS7BDAT files with zero rows

* Add missing file

* Update test_sas7bdat.py
mroeschke pushed a commit that referenced this pull request Jun 24, 2022
* Fix reading SAS7BDAT files with zero rows (#47116)

* Fix reading SAS7BDAT files with zero rows

* Add missing file

* Update test_sas7bdat.py

* Review feedback

* Add back untested .rstrip

* Fix lint

* Add tests

* Fix rebase
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* Fix reading SAS7BDAT files with zero rows

* Add missing file

* Update test_sas7bdat.py
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
…v#47113)

* Fix reading SAS7BDAT files with zero rows (pandas-dev#47116)

* Fix reading SAS7BDAT files with zero rows

* Add missing file

* Update test_sas7bdat.py

* Review feedback

* Add back untested .rstrip

* Fix lint

* Add tests

* Fix rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug IO SAS SAS: read_sas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading a SAS file with 0 rows gives None
4 participants