Fix SAS 0x40 control byte handling and column name parsing #47113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonashaag
force-pushed
the
issue-31243
branch
5 times, most recently
from
96856b6 to
050ec0a
Compare
mroeschke
reviewed
Jun 3, 2022
mroeschke
reviewed
Jun 3, 2022
mroeschke
reviewed
Jun 3, 2022
* Fix reading SAS7BDAT files with zero rows * Add missing file * Update test_sas7bdat.py
|
Hello @jonashaag! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-06-15 20:39:47 UTC |
mroeschke
reviewed
Jun 9, 2022
mroeschke
approved these changes
Jun 9, 2022
|
we don't have an explict test file for this that repros? |
|
Oh wow, thanks for checking, this must have gone lost during a rebase. |
jreback
approved these changes
Jun 24, 2022
|
Thanks @jonashaag |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…v#47113) * Fix reading SAS7BDAT files with zero rows (pandas-dev#47116) * Fix reading SAS7BDAT files with zero rows * Add missing file * Update test_sas7bdat.py * Review feedback * Add back untested .rstrip * Fix lint * Add tests * Fix rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.