ENH: move DataError from core/base.py to error/__init__.py per GH27656 #47047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
May 19, 2022
doc/source/whatsnew/v1.5.0.rst
Outdated
| @@ -150,6 +150,7 @@ Other enhancements | |||
| - Added ``validate`` argument to :meth:`DataFrame.join` (:issue:`46622`) | |||
| - A :class:`errors.PerformanceWarning` is now thrown when using ``string[pyarrow]`` dtype with methods that don't dispatch to ``pyarrow.compute`` methods (:issue:`42613`) | |||
| - Added ``numeric_only`` argument to :meth:`Resampler.sum`, :meth:`Resampler.prod`, :meth:`Resampler.min`, :meth:`Resampler.max`, :meth:`Resampler.first`, and :meth:`Resampler.last` (:issue:`46442`) | |||
| - Moved :class:`DataError` from ``pandas.core.base`` to ``pandas.errors`` (:issue:`27656`) | |||
There was a problem hiding this comment.
this is not necessary as there isn't a visible user change (pandas.core is considered private). so you can re-word to say its now exposed in pandas.errors or just omit the note is ok too.
There was a problem hiding this comment.
Thank you for the feedback, I've reworded the note
|
thanks @dataxerik |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v1.5.0.rstfile if fixing a bug or adding a new feature.