ENH: move DataError from core/base.py to error/__init__.py per GH27656 (pandas-dev#47047)

Author: dataxerik

doc/source/reference/testing.rst

@@ -26,6 +26,7 @@ Exceptions and warnings
 
    errors.AbstractMethodError
    errors.AccessorRegistrationWarning
+   errors.DataError
    errors.DtypeWarning
    errors.DuplicateLabelError
    errors.EmptyDataError

doc/source/whatsnew/v1.5.0.rst

@@ -151,6 +151,7 @@ Other enhancements
 - A :class:`errors.PerformanceWarning` is now thrown when using ``string[pyarrow]`` dtype with methods that don't dispatch to ``pyarrow.compute`` methods (:issue:`42613`)
 - Added ``numeric_only`` argument to :meth:`Resampler.sum`, :meth:`Resampler.prod`, :meth:`Resampler.min`, :meth:`Resampler.max`, :meth:`Resampler.first`, and :meth:`Resampler.last` (:issue:`46442`)
 - ``times`` argument in :class:`.ExponentialMovingWindow` now accepts ``np.timedelta64`` (:issue:`47003`)
+- :class:`DataError` now exposed in ``pandas.errors`` (:issue:`27656`)
 
 .. ---------------------------------------------------------------------------
 .. _whatsnew_150.notable_bug_fixes:

pandas/core/apply.py

@@ -33,6 +33,7 @@
     Axis,
     NDFrameT,
 )
+from pandas.errors import DataError
 from pandas.util._decorators import cache_readonly
 from pandas.util._exceptions import find_stack_level
 
@@ -51,7 +52,6 @@
 
 from pandas.core.algorithms import safe_sort
 from pandas.core.base import (
-    DataError,
     SelectionMixin,
     SpecificationError,
 )

pandas/core/base.py

@@ -176,10 +176,6 @@ def __setattr__(self, key: str, value):
         object.__setattr__(self, key, value)
 
 
-class DataError(Exception):
-    pass
-
-
 class SpecificationError(Exception):
     pass
 

pandas/core/groupby/groupby.py

@@ -53,7 +53,10 @@ class providing the base-class of operations.
     npt,
 )
 from pandas.compat.numpy import function as nv
-from pandas.errors import AbstractMethodError
+from pandas.errors import (
+    AbstractMethodError,
+    DataError,
+)
 from pandas.util._decorators import (
     Appender,
     Substitution,
@@ -89,7 +92,6 @@ class providing the base-class of operations.
     ExtensionArray,
 )
 from pandas.core.base import (
-    DataError,
     PandasObject,
     SelectionMixin,
 )

pandas/core/resample.py

@@ -34,7 +34,10 @@
     npt,
 )
 from pandas.compat.numpy import function as nv
-from pandas.errors import AbstractMethodError
+from pandas.errors import (
+    AbstractMethodError,
+    DataError,
+)
 from pandas.util._decorators import (
     Appender,
     Substitution,
@@ -50,10 +53,7 @@
 
 import pandas.core.algorithms as algos
 from pandas.core.apply import ResamplerWindowApply
-from pandas.core.base import (
-    DataError,
-    PandasObject,
-)
+from pandas.core.base import PandasObject
 import pandas.core.common as com
 from pandas.core.generic import (
     NDFrame,

pandas/core/window/rolling.py

@@ -33,6 +33,7 @@
 )
 from pandas.compat._optional import import_optional_dependency
 from pandas.compat.numpy import function as nv
+from pandas.errors import DataError
 from pandas.util._decorators import doc
 from pandas.util._exceptions import find_stack_level
 
@@ -54,10 +55,7 @@
 from pandas.core.algorithms import factorize
 from pandas.core.apply import ResamplerWindowApply
 from pandas.core.arrays import ExtensionArray
-from pandas.core.base import (
-    DataError,
-    SelectionMixin,
-)
+from pandas.core.base import SelectionMixin
 import pandas.core.common as com
 from pandas.core.indexers.objects import (
     BaseIndexer,

pandas/errors/__init__.py

@@ -236,3 +236,11 @@ class InvalidIndexError(Exception):
 
     .. versionadded:: 1.1.0
     """
+
+
+class DataError(Exception):
+    """
+    Exception raised when trying to perform a ohlc on a non-numnerical column.
+    Or, it can be raised when trying to apply a function to a non-numerical
+    column on a rolling window.
+    """

pandas/tests/test_errors.py

@@ -19,6 +19,7 @@
         "MergeError",
         "OptionError",
         "NumbaUtilError",
+        "DataError",
     ],
 )
 def test_exception_importable(exc):

pandas/tests/window/test_dtypes.py

@@ -1,6 +1,8 @@
 import numpy as np
 import pytest
 
+from pandas.errors import DataError
+
 from pandas.core.dtypes.common import pandas_dtype
 
 from pandas import (
@@ -9,7 +11,6 @@
     Series,
 )
 import pandas._testing as tm
-from pandas.core.base import DataError
 
 # gh-12373 : rolling functions error on float32 data
 # make sure rolling functions works for different dtypes