Skip to content

ENH: validates boolean kwargs in DataFrame and Series methods #46938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

ENH: validates boolean kwargs in DataFrame and Series methods #46938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9461158
add validate_bool_kwargs_from_keywords to methods
Condielj May 4, 2022
6f1c2d6
Delete frame.py
Condielj May 4, 2022
2b43b3c
added validate_bool_kwargs_from_keywords
Condielj May 4, 2022
05d1347
added test for validate_bool_kwargs_from_keywords
Condielj May 4, 2022
4c5bc99
added test for validate_bool_kwargs_from_keywords
Condielj May 4, 2022
3cfff6c
ENH: validate_bool_kwargs_from_keywords for kwargs
Condielj May 4, 2022
aab4523
DOC: updated whatsnew pandas-dev#16714
Condielj May 4, 2022
3cab1f2
ENH: validate bool kwargs (#16714)
Condielj May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.5.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ Other enhancements
- Added ``validate`` argument to :meth:`DataFrame.join` (:issue:`46622`)
- A :class:`errors.PerformanceWarning` is now thrown when using ``string[pyarrow]`` dtype with methods that don't dispatch to ``pyarrow.compute`` methods (:issue:`42613`)
- Added ``numeric_only`` argument to :meth:`Resampler.sum`, :meth:`Resampler.prod`, :meth:`Resampler.min`, :meth:`Resampler.max`, :meth:`Resampler.first`, and :meth:`Resampler.last` (:issue:`46442`)
- Added validation of boolean kwargs in string series and DataFrame methods, along with tests (:issue:`16714`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls be very specific on which methods / kwargs are updated here a reader is not going to find this note useful.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would also put this in the appropriate bug fix categories (even if you do multiple notes is ok)


.. ---------------------------------------------------------------------------
.. _whatsnew_150.notable_bug_fixes:
Expand Down
Loading