ENH: validates boolean kwargs in DataFrame and Series methods #46938
Conversation
|
Hello @Condielj! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
| @@ -125,6 +125,7 @@ Other enhancements | |||
| - Added ``validate`` argument to :meth:`DataFrame.join` (:issue:`46622`) | |||
| - A :class:`errors.PerformanceWarning` is now thrown when using ``string[pyarrow]`` dtype with methods that don't dispatch to ``pyarrow.compute`` methods (:issue:`42613`) | |||
| - Added ``numeric_only`` argument to :meth:`Resampler.sum`, :meth:`Resampler.prod`, :meth:`Resampler.min`, :meth:`Resampler.max`, :meth:`Resampler.first`, and :meth:`Resampler.last` (:issue:`46442`) | |||
| - Added validation of boolean kwargs in string series and DataFrame methods, along with tests (:issue:`16714`) | |||
There was a problem hiding this comment.
pls be very specific on which methods / kwargs are updated here a reader is not going to find this note useful.
There was a problem hiding this comment.
i would also put this in the appropriate bug fix categories (even if you do multiple notes is ok)
| @@ -518,3 +520,39 @@ def validate_insert_loc(loc: int, length: int) -> int: | |||
| if not 0 <= loc <= length: | |||
| raise IndexError(f"loc must be an integer between -{length} and {length}") | |||
| return loc | |||
|
|
|||
| def validate_bool_kwargs_from_keywords(*keywords): | |||
There was a problem hiding this comment.
umm why cannot we juse call the existng validate_bool_kwarg? why make yet another function?
jreback
added
the
Compat
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
(First commit is an extra frame.py and the second is deleting it- all frame.py's are in the right place)