Skip to content

DOC: fix SA04 errors flagged by validate_docstrings.py and add SA04 t… #46652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 12, 2022

Conversation

dataxerik
Copy link
Contributor

Many of the SA04 reported in #25337 are already fixed, but there were two outstanding SA04 errors reported by valdiate_docstrings.py on main. So, I fixed those and added 'SA04' to the code_checks.py as per #25337

@mroeschke mroeschke added the Docs label Apr 7, 2022
@mroeschke mroeschke added this to the 1.5 milestone Apr 12, 2022
@mroeschke mroeschke merged commit c90294d into pandas-dev:main Apr 12, 2022
@mroeschke
Copy link
Member

Thanks @dataxerik

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
pandas-dev#46652)

* DOC: fix SA04 errors flagged by validate_docstrings.py and add SA04 to code_checks.sh

* DOC: apply feedback

* DOC: change Series/Dataframe to just Dataframe

* DOC: move to one line

Co-authored-by: Derek Sharp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix validation error type SA04 and check in CI
2 participants