Skip to content

Fix validation error type SA04 and check in CI #25337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
MarckK opened this issue Feb 15, 2019 · 3 comments · Fixed by #46652
Closed
2 tasks

Fix validation error type SA04 and check in CI #25337

MarckK opened this issue Feb 15, 2019 · 3 comments · Fixed by #46652
Assignees
@dataxerik
Labels
CI Continuous Integration Code Style Code style, linting, code_checks Docs good first issue

Comments

@MarckK
Copy link
Contributor

MarckK commented Feb 15, 2019 •
edited
Loading

Problem description

In order to have a continuous check by the CI on validation error SA04 (Missing description for See Also reference), fixing them in the code base enables the addition to the CI for automated testing in the future.

Please see overview of the errors.

Todo:

  • get rid of the errors in the code base
  • update the code_check.sh script to take into account the SA04 type of errors
@Sedosa
Copy link
Contributor

Sedosa commented Feb 16, 2019

Hi! May I work on this?

@MarckK
Copy link
Contributor Author

MarckK commented Feb 16, 2019

Yes, please do @Sedosa :)

@Sedosa Sedosa mentioned this issue Feb 17, 2019
Closed
2 tasks
@gfyoung gfyoung added CI Continuous Integration Code Style Code style, linting, code_checks Docs labels Feb 18, 2019
@jreback jreback added this to the 0.25.0 milestone Feb 19, 2019
@jreback jreback modified the milestones: 0.25.0, Contributions Welcome Apr 20, 2019
@dataxerik
Copy link
Contributor

take

@dataxerik dataxerik mentioned this issue Apr 6, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dataxerik dataxerik

Labels
CI Continuous Integration Code Style Code style, linting, code_checks Docs good first issue
Projects
None yet
Milestone
No milestone
6 participants
@jreback @gfyoung @simonjayhawkins @MarckK @dataxerik @Sedosa