CI: Remove grep from asv call (using strict parameter instead) #46633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
added
CI
|
Looks like this is working as expected, CI will now fail if benchmarks break, without the grep hack: https://github.com/pandas-dev/pandas/runs/5817260505?check_suite_focus=true#step:6:12445 |
datapythonista
changed the title
mroeschke
approved these changes
Apr 5, 2022
This comment was marked as resolved.
This comment was marked as resolved.
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Apr 10, 2022
…s-dev#46633) (cherry picked from commit c8cbe19)
jreback
pushed a commit
that referenced
this pull request
Apr 10, 2022
…ing strict parameter instead)) (#46727) Co-authored-by: Marc Garcia <[email protected]>
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like asv didn't fail the CI, because if requires a
--strictparameter to do so. Adding it here. And will change this behavior in asv: airspeed-velocity/asv#1199Adding a failing benchmark to make sure this works as expected. Will remove if CI is red because of it.