Skip to content

Commit dfbc1dc

Browse files
Backport PR #46633 on branch 1.4.x (CI: Remove grep from asv call (using strict parameter instead)) (#46727)
Co-authored-by: Marc Garcia <[email protected]>
1 parent 5432af2 commit dfbc1dc

File tree

3 files changed

+3
-17
lines changed

3 files changed

+3
-17
lines changed

.github/workflows/code-checks.yml

+1-15
Original file line numberDiff line numberDiff line change
@@ -140,22 +140,8 @@ jobs:
140140
- name: Run ASV benchmarks
141141
run: |
142142
cd asv_bench
143-
asv check -E existing
144-
git remote add upstream https://github.com/pandas-dev/pandas.git
145-
git fetch upstream
146143
asv machine --yes
147-
asv dev | sed "/failed$/ s/^/##[error]/" | tee benchmarks.log
148-
if grep "failed" benchmarks.log > /dev/null ; then
149-
exit 1
150-
fi
151-
if: ${{ steps.build.outcome == 'success' }}
152-
153-
- name: Publish benchmarks artifact
154-
uses: actions/upload-artifact@v3
155-
with:
156-
name: Benchmarks log
157-
path: asv_bench/benchmarks.log
158-
if: failure()
144+
asv run --quick --dry-run --strict --durations=30 --python=same
159145
160146
build_docker_dev_environment:
161147
name: Build Docker Dev Environment

environment.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ dependencies:
99
- pytz
1010

1111
# benchmarks
12-
- asv < 0.5.0 # 2022-02-08: v0.5.0 > leads to ASV checks running > 3 hours on CI
12+
- asv
1313

1414
# building
1515
# The compiler packages are meta-packages and install the correct compiler (activation) packages on the respective platforms.

requirements-dev.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
numpy>=1.18.5
55
python-dateutil>=2.8.1
66
pytz
7-
asv < 0.5.0
7+
asv
88
cython>=0.29.24
99
black==22.3.0
1010
cpplint

0 commit comments

Comments
 (0)