Skip to content

CI: Don't run PANDAS_DATA_MANAGER=array test for downstream tests #46253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 8, 2022
Merged

CI: Don't run PANDAS_DATA_MANAGER=array test for downstream tests #46253

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ead63e7
CI: Have arraymanager tests use PYTEST_TARGET
mroeschke Mar 7, 2022
ff16783
Okay if no downstream tests are run for arraymanager
mroeschke Mar 7, 2022
5673f23
Confirm 5 is from pytest
mroeschke Mar 7, 2022
5dfe33f
only run if targeting pandas
mroeschke Mar 7, 2022
deeb4f9
Forgot quotes
mroeschke Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ci/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,10 @@ fi
echo $PYTEST_CMD
sh -c "$PYTEST_CMD"

if [[ "$PANDAS_DATA_MANAGER" != "array" ]]; then
if [[ "$PANDAS_DATA_MANAGER" != "array" && "$PYTEST_TARGET" == "pandas" ]]; then
# The ArrayManager tests should have already been run by PYTEST_CMD if PANDAS_DATA_MANAGER was already set to array
PYTEST_AM_CMD="PANDAS_DATA_MANAGER=array pytest -n $PYTEST_WORKERS --dist=loadfile $TEST_ARGS $COVERAGE pandas"
# If we're targeting specific files, e.g. test_downstream.py, don't run.
PYTEST_AM_CMD="PANDAS_DATA_MANAGER=array pytest -n $PYTEST_WORKERS --dist=loadfile $TEST_ARGS $COVERAGE pandas"

if [[ "$PATTERN" ]]; then
PYTEST_AM_CMD="$PYTEST_AM_CMD -m \"$PATTERN and arraymanager\""
Expand Down