Skip to content

CI: Don't run PANDAS_DATA_MANAGER=array test for downstream tests #46253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 8, 2022

Conversation

mroeschke
Copy link
Member

This should shorten the downstream build such that pandas/tests/test_downstream.py is run instead of pandas/

@mroeschke mroeschke added the CI Continuous Integration label Mar 7, 2022
@jreback jreback added this to the 1.5 milestone Mar 8, 2022
@mroeschke mroeschke changed the title CI: Have arraymanager tests use PYTEST_TARGET CI: Don't run PANDAS_DATA_MANAGER=array test for downstream tests Mar 8, 2022
@jreback
Copy link
Contributor

jreback commented Mar 8, 2022

looks fine, can you double confirm that now running the correct tests (and not running what not supposed to) and doesn't break other builds

@mroeschke
Copy link
Member Author

looks fine, can you double confirm that now running the correct tests (and not running what not supposed to) and doesn't break other builds

Downstream build:

xvfb-run pytest -r fEs -n auto --dist=loadfile -s --cov=pandas --cov-report=xml --cov-append pandas/tests/test_downstream.py -m "not slow and not network and not single_cpu"
============================= test session starts ==============================
platform linux -- Python 3.8.12, pytest-7.0.1, pluggy-1.0.0
rootdir: /home/runner/work/pandas/pandas, configfile: pyproject.toml
plugins: hypothesis-6.39.2, xdist-2.5.0, forked-1.4.0, cov-3.0.0
gw0 I / gw1 I
gw0 [13] / gw1 [13]

.............
------ generated xml file: /home/runner/work/pandas/pandas/test-data.xml -------

---------- coverage: platform linux, python 3.8.12-final-0 -----------
Coverage XML written to file coverage.xml

============================= slowest 30 durations =============================
2.29s call     pandas/tests/test_downstream.py::test_oo_optimizable
1.26s call     pandas/tests/test_downstream.py::test_torch_frame_construction
0.86s call     pandas/tests/test_downstream.py::test_missing_required_dependency
0.84s call     pandas/tests/test_downstream.py::test_oo_optimized_datetime_index_unpickle
0.35s call     pandas/tests/test_downstream.py::test_geopandas
0.31s call     pandas/tests/test_downstream.py::test_scikit_learn
0.14s call     pandas/tests/test_downstream.py::test_dask
0.04s call     pandas/tests/test_downstream.py::test_yaml_dump
0.01s call     pandas/tests/test_downstream.py::test_pandas_gbq
0.01s call     pandas/tests/test_downstream.py::test_dask_ufunc
0.01s call     pandas/tests/test_downstream.py::test_pyarrow
0.01s setup    pandas/tests/test_downstream.py::test_dask

(18 durations < 0.005s hidden.  Use -vv to show these durations.)
============================= 13 passed in 24.33s ==============================

Non downstream build

xvfb-run pytest -r fEs -n auto --dist=loadfile -s --cov=pandas --cov-report=xml --cov-append pandas -m "not single_cpu"
============================= test session starts ==============================
platform linux -- Python 3.8.12, pytest-7.0.1, pluggy-1.0.0
rootdir: /home/runner/work/pandas/pandas, configfile: pyproject.toml, testpaths: pandas
plugins: hypothesis-6.39.2, xdist-2.5.0, forked-1.4.0, cov-3.0.0
gw0 I / gw1 I
gw0 [164036] / gw1 [164036]

...

= 161531 passed, 1186 skipped, 1317 xfailed, 2 xpassed, 28 warnings in 2492.74s (0:41:32) =

PANDAS_DATA_MANAGER=array pytest -n auto --dist=loadfile -s --cov=pandas --cov-report=xml --cov-append pandas -m "not single_cpu and arraymanager"
============================= test session starts ==============================
platform linux -- Python 3.8.12, pytest-7.0.1, pluggy-1.0.0
rootdir: /home/runner/work/pandas/pandas, configfile: pyproject.toml, testpaths: pandas
plugins: hypothesis-6.39.2, xdist-2.5.0, forked-1.4.0, cov-3.0.0
gw0 I / gw1 I
gw0 [7894] / gw1 [7894]

...

= 7506 passed, 77 skipped, 309 xfailed, 2 xpassed, 18 warnings in 267.15s (0:04:27) =

@jreback jreback merged commit d0cf9b5 into pandas-dev:main Mar 8, 2022
@mroeschke mroeschke deleted the ci/arraymanager_downstream branch March 8, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants