REGR: drop raising with ea index and duplicates #45983
Conversation
phofl
added
Regression
pandas/core/generic.py
Outdated
| @@ -4342,6 +4342,9 @@ def _drop_axis( | |||
| if errors == "raise" and labels_missing: | |||
| raise KeyError(f"{labels} not found in axis") | |||
|
|
|||
| if is_extension_array_dtype(mask.dtype): | |||
| mask = mask.to_numpy() | |||
There was a problem hiding this comment.
if mask is BooleanArray, then we need to specify dtype=bool otherwise we get object dtype here. or could implement EA.nonzero.
comment with GH ref?
There was a problem hiding this comment.
Thx added the dtype and comment. I must have removed the dtype somehow after fixing this
| def test_drop_index_ea_dtype(self, any_numeric_ea_dtype, idx, level): | ||
| # GH#45860 | ||
| df = DataFrame( | ||
| {"a": [1, 2, 2], "b": 100}, dtype=any_numeric_ea_dtype |
There was a problem hiding this comment.
Added one more element, but this should not matter in this case I think
There was a problem hiding this comment.
the case i had in mind is where the BooleanArray mask that this PR casts to ndarray contains a pd.NA. Is that not reachable?
There was a problem hiding this comment.
Ah got you. I don't think so no. Having NA on both sides evaluates to False. Added the case
| if is_extension_array_dtype(mask.dtype): | ||
| # GH#45860 | ||
| mask = mask.to_numpy(dtype=bool) | ||
|
|
There was a problem hiding this comment.
i guess we maybe want to define .nonzero() on EA arrays
|
@meeseeksdev backport 1.4.x |
|
Something went wrong ... Please have a look at my logs. |
…46020) Co-authored-by: Patrick Hoefler <[email protected]>
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.We handle this case similarly for loc