Skip to content

ENH: define nonzero() on extension arrays #46025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
phofl opened this issue Feb 16, 2022 · 1 comment
Open

ENH: define nonzero() on extension arrays #46025

phofl opened this issue Feb 16, 2022 · 1 comment
Labels
Enhancement ExtensionArray Extending pandas with custom dtypes or arrays.

Comments

@phofl
Copy link
Member

phofl commented Feb 16, 2022

This caused a few issues when we got a Boolean-Dtype extension array which was used as mask/indexer instead of a numpy array. See #45983

We can avoid this through definining nonzero on ea arrays.
@phofl phofl added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Feb 16, 2022
@phofl phofl mentioned this issue Feb 16, 2022
Merged
4 tasks
@mroeschke mroeschke added ExtensionArray Extending pandas with custom dtypes or arrays. and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Mar 16, 2022
@jbrockmendel
Copy link
Member

do NAs count as nonzero?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbrockmendel @mroeschke @phofl