Skip to content

BUG: Concatenating categorical datetime columns raises a ValueError since v1.2 #45926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

BUG: Concatenating categorical datetime columns raises a ValueError since v1.2 #45926

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fd45ab2
Fixing documentation format in read_csv
eshirvana Feb 7, 2022
098c170
Merge branch 'pandas-dev:main' into main
eshirvana Feb 7, 2022
f2caa9e
Merge branch 'pandas-dev:main' into main
eshirvana Feb 10, 2022
3bbe856
TST: GH39443 - categorical datetime concat
eshirvana Feb 10, 2022
5e132b5
Merge branch 'main' into issue39443-test-unit-datetime
eshirvana Feb 11, 2022
5868a55
shorten the code lines
eshirvana Feb 11, 2022
d91c7e1
Merge branch 'main' into issue39443-test-unit-datetime
eshirvana Feb 11, 2022
80005c7
Merge branch 'main' into issue39443-test-unit-datetime
eshirvana Mar 26, 2022
462a703
Merge branch 'main' into issue39443-test-unit-datetime
eshirvana Mar 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion pandas/tests/reshape/concat/test_categorical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import numpy as np

from datetime import datetime
from pandas.core.dtypes.dtypes import CategoricalDtype

import pandas as pd
Expand Down Expand Up @@ -169,6 +169,19 @@ def test_concat_categorical_tz(self):
)
tm.assert_series_equal(result, expected)

def test_concat_categorical_datetime(self):
# GH-39443
df1 = DataFrame(
{"x": Series(datetime(2021, 1, 1), index=[0], dtype="category")})
df2 = DataFrame(
{"x": Series(datetime(2021, 1, 2), index=[1], dtype="category")})

result = pd.concat([df1, df2])
expected = DataFrame(
{"x": Series([datetime(2021, 1, 1), datetime(2021, 1, 2)])})

tm.assert_equal(result, expected)

def test_concat_categorical_unchanged(self):
# GH-12007
# test fix for when concat on categorical and float
Expand Down