Skip to content

BUG: Concatenating categorical datetime columns raises a ValueError since v1.2 #45926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

eshirvana
Copy link
Contributor

@eshirvana eshirvana commented Feb 10, 2022

eshirvana and others added 4 commits February 6, 2022 21:31
add a mising ` in on_bad_lines option description in " New in version 1.3.0: " section , that was causing to make couple of lines red
@pep8speaks
Copy link

pep8speaks commented Feb 10, 2022

Hello @eshirvana! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-03-28 16:33:33 UTC

@jreback jreback added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite labels Feb 11, 2022
@jreback jreback added this to the 1.5 milestone Feb 11, 2022
@jreback jreback changed the title Issue39443 test unit datetime BUG: Concatenating categorical datetime columns raises a ValueError since v1.2 Feb 11, 2022
@jreback
Copy link
Contributor

jreback commented Mar 6, 2022

can you merge master and ping when passing

@eshirvana eshirvana marked this pull request as ready for review March 26, 2022 02:10
@eshirvana
Copy link
Contributor Author

eshirvana commented Mar 26, 2022

can you merge master and ping when passing

@jreback done

@eshirvana eshirvana closed this Mar 28, 2022
@eshirvana eshirvana reopened this Mar 28, 2022
@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Apr 28, 2022
@mroeschke
Copy link
Member

Thanks for the pull request, but it appear to have gone stale. If interested in continuing, please merge in main, address the failures in the CI, and we can reopen.

@mroeschke mroeschke closed this May 7, 2022
@eshirvana eshirvana deleted the issue39443-test-unit-datetime branch July 7, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reshaping Concat, Merge/Join, Stack/Unstack, Explode Stale Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Concatenating categorical datetime columns raises a ValueError since v1.2
4 participants