Skip to content

CI/TST: add is_ci_environment to test_close_file_handle_on_invalid_usecols skip #45872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

simonjayhawkins
Copy link
Member

follow-up to #45507 and #45771, xref #45786 (comment)

@simonjayhawkins simonjayhawkins added Testing pandas testing functions or related to the test suite CI Continuous Integration labels Feb 8, 2022
@mroeschke mroeschke added this to the 1.4.1 milestone Feb 8, 2022
@mroeschke mroeschke merged commit b7184d9 into pandas-dev:main Feb 8, 2022
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 8, 2022
@mroeschke
Copy link
Member

Thanks @simonjayhawkins for catching this.

@mroeschke
Copy link
Member

@meeseeksdev backport 1.4.x

@lumberbot-app
Copy link

lumberbot-app bot commented Feb 8, 2022

Something went wrong ... Please have a look at my logs.

@simonjayhawkins simonjayhawkins deleted the test-followup branch February 8, 2022 17:36
@simonjayhawkins
Copy link
Member Author

Thanks @simonjayhawkins for catching this.

should maybe do this for check_for_file_leaks and file_leak_context in #45702?

@mroeschke
Copy link
Member

Thanks @simonjayhawkins for catching this.

should maybe do this for check_for_file_leaks and file_leak_context in #45702?

Good point. Yeah those changes should be CI specific too.

simonjayhawkins added a commit that referenced this pull request Feb 8, 2022
…handle_on_invalid_usecols skip (#45879)

Co-authored-by: Simon Hawkins <[email protected]>
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants