TST: Skip flaky, crashing test in Windows #45786

mroeschke · 2022-02-02T22:13:06Z

Tests added and passed if fixing a bug or adding a new feature
All code checks passed.

Discovered while working on #45478

Logs: https://dev.azure.com/pandas-dev/e01c9671-576d-40f3-a1a1-7bef78604087/_apis/build/builds/73534/logs/54

2022-02-02T19:12:27.1410114Z pandas/tests/test_sorting.py::TestSafeSort::test_codes_out_of_bound[-1] Windows fatal exception: access violation
2022-02-02T19:12:27.1411407Z 
2022-02-02T19:12:27.1414872Z Thread 0x000011cc (most recent call first):
2022-02-02T19:12:27.1417026Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 400 in read
2022-02-02T19:12:27.1418547Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 432 in from_io
2022-02-02T19:12:27.1420140Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 967 in _thread_receiver
2022-02-02T19:12:27.1424677Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 220 in run
2022-02-02T19:12:27.1426225Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 285 in _perform_spawn
2022-02-02T19:12:27.1427290Z 
2022-02-02T19:12:27.1428448Z Current thread 0x00001088 (most recent call first):
2022-02-02T19:12:27.1434554Z   File "D:\a\1\s\pandas\core\array_algos\take.py", line 163 in _take_nd_ndarray
2022-02-02T19:12:27.1435976Z   File "D:\a\1\s\pandas\core\array_algos\take.py", line 117 in take_nd
2022-02-02T19:12:27.1438483Z   File "D:\a\1\s\pandas\core\algorithms.py", line 1771 in safe_sort
2022-02-02T19:12:27.1441486Z   File "D:\a\1\s\pandas\tests\test_sorting.py", line 434 in test_codes_out_of_bound
2022-02-02T19:12:27.1447616Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\_pytest\python.py", line 183 in pytest_pyfunc_call
2022-02-02T19:12:27.1450037Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\pluggy\_callers.py", line 39 in _multicall
2022-02-02T19:12:27.1455665Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\pluggy\_manager.py", line 80 in _hookexec
2022-02-02T19:12:27.1458131Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\pluggy\_hooks.py", line 265 in __call__
2022-02-02T19:12:27.1461448Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\_pytest\python.py", line 1641 in runtest
2022-02-02T19:12:27.1466555Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\_pytest\runner.py", line 162 in pytest_runtest_call
2022-02-02T19:12:27.1474703Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\pluggy\_callers.py", line 39 in _multicall
2022-02-02T19:12:27.1477211Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\pluggy\_manager.py", line 80 in _hookexec
2022-02-02T19:12:27.1479949Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\pluggy\_hooks.py", line 265 in __call__
2022-02-02T19:12:27.1483707Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\_pytest\runner.py", line 255 in <lambda>
2022-02-02T19:12:27.1487056Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\_pytest\runner.py", line 311 in from_call
2022-02-02T19:12:27.1490846Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\_pytest\runner.py", line 254 in call_runtest_hook
2022-02-02T19:12:27.1496618Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\_pytest\runner.py", line 215 in call_and_report
2022-02-02T19:12:27.1498412Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\_pytest\runner.py", line 126 in runtestprotocol
2022-02-02T19:12:27.1501905Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\_pytest\runner.py", line 109 in pytest_runtest_protocol
2022-02-02T19:12:27.1503892Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\pluggy\_callers.py", line 39 in _multicall
2022-02-02T19:12:27.1505686Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\pluggy\_manager.py", line 80 in _hookexec
2022-02-02T19:12:27.1508520Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\pluggy\_hooks.py", line 265 in __call__
2022-02-02T19:12:27.1515729Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\xdist\remote.py", line 110 in run_one_test
2022-02-02T19:12:27.1517749Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\xdist\remote.py", line 91 in pytest_runtestloop
2022-02-02T19:12:27.1520191Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\pluggy\_callers.py", line 39 in _multicall
2022-02-02T19:12:27.1522404Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\pluggy\_manager.py", line 80 in _hookexec
2022-02-02T19:12:27.1524427Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\pluggy\_hooks.py", line 265 in __call__
2022-02-02T19:12:27.1526201Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\_pytest\main.py", line 323 in _main
2022-02-02T19:12:27.1528352Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\_pytest\main.py", line 269 in wrap_session
2022-02-02T19:12:27.1531223Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\_pytest\main.py", line 316 in pytest_cmdline_main
2022-02-02T19:12:27.1533340Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\pluggy\_callers.py", line 39 in _multicall
2022-02-02T19:12:27.1536051Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\pluggy\_manager.py", line 80 in _hookexec
2022-02-02T19:12:27.1538727Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\pluggy\_hooks.py", line 265 in __call__
2022-02-02T19:12:27.1541284Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\xdist\remote.py", line 291 in <module>
2022-02-02T19:12:27.1543577Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 1084 in executetask
2022-02-02T19:12:27.1545576Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 220 in run
2022-02-02T19:12:27.1547427Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 285 in _perform_spawn
2022-02-02T19:12:27.1549546Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 267 in integrate_as_primary_thread
2022-02-02T19:12:27.1553621Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 1060 in serve
2022-02-02T19:12:27.1555282Z   File "C:\Miniconda\envs\pandas-dev\lib\site-packages\execnet\gateway_base.py", line 1554 in serve
2022-02-02T19:12:27.1556281Z   File "<string>", line 8 in <module>
2022-02-02T19:12:27.1558066Z   File "<string>", line 1 in <module>
2022-02-02T19:12:27.1604672Z 
2022-02-02T19:12:27.1606666Z [gw0] node down: Not properly terminated
2022-02-02T19:12:27.3719566Z [gw0] FAILED pandas/tests/test_sorting.py::TestSafeSort::test_codes_out_of_bound[-1] 
2022-02-02T19:12:27.3723006Z 
2022-02-02T19:12:27.3724654Z replacing crashed worker gw0

jbrockmendel · 2022-02-03T02:16:48Z

pandas/tests/test_sorting.py

@@ -424,6 +426,11 @@ def test_codes(self, verify, codes, exp_codes, na_sentinel):
        tm.assert_numpy_array_equal(result, expected)
        tm.assert_numpy_array_equal(result_codes, expected_codes)

+    @pytest.mark.skipif(
+        is_platform_windows(),


should do the os.environ("CI") check?

individually the skips you've been adding over the last couple weeks all make sense, but added up they make me nervous that we're losing non-trivial coverage

yeah seems reasonable (could make an easy skip for this too)

Yup make sense (I'll follow up by making a pandas.compat.is_ci_environment function)

…violations

jreback · 2022-02-03T18:19:42Z

lgtm merge on green (and backport)

mroeschke · 2022-02-03T19:06:14Z

@meeseeksdev backport 1.4.x

lumberbot-app · 2022-02-03T19:06:47Z

Something went wrong ... Please have a look at my logs.

Co-authored-by: Matthew Roeschke <[email protected]>

* TST: Skip flaky, crashing test in Windows * Add CI check

TST: Skip flaky, crashing test in Windows

727f1fd

jbrockmendel reviewed Feb 3, 2022

View reviewed changes

jreback added Testing pandas testing functions or related to the test suite Windows Windows OS labels Feb 3, 2022

jbrockmendel approved these changes Feb 3, 2022

View reviewed changes

mroeschke added 2 commits February 3, 2022 09:35

Merge remote-tracking branch 'upstream/main' into tst/windows_access_…

9fb8a9b

…violations

Add CI check

f19cce1

jreback added this to the 1.4.1 milestone Feb 3, 2022

mroeschke merged commit 7651c08 into pandas-dev:main Feb 3, 2022

mroeschke deleted the tst/windows_access_violations branch February 3, 2022 19:05

meeseeksmachine mentioned this pull request Feb 3, 2022

Backport PR #45786 on branch 1.4.x (TST: Skip flaky, crashing test in Windows) #45805

Merged

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 3, 2022

Backport PR pandas-dev#45786: TST: Skip flaky, crashing test in Windows

4227cb3

jreback pushed a commit that referenced this pull request Feb 4, 2022

Backport PR #45786: TST: Skip flaky, crashing test in Windows (#45805)

7a72206

Co-authored-by: Matthew Roeschke <[email protected]>

simonjayhawkins mentioned this pull request Feb 8, 2022

CI/TST: add is_ci_environment to test_close_file_handle_on_invalid_usecols skip #45872

Merged

phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022

TST: Skip flaky, crashing test in Windows (pandas-dev#45786)

8316df9

* TST: Skip flaky, crashing test in Windows * Add CI check

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022

TST: Skip flaky, crashing test in Windows (pandas-dev#45786)

ee0e50d

* TST: Skip flaky, crashing test in Windows * Add CI check

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TST: Skip flaky, crashing test in Windows #45786

TST: Skip flaky, crashing test in Windows #45786

mroeschke commented Feb 2, 2022

jbrockmendel Feb 3, 2022

jreback Feb 3, 2022

mroeschke Feb 3, 2022

jreback commented Feb 3, 2022

mroeschke commented Feb 3, 2022

lumberbot-app bot commented Feb 3, 2022

TST: Skip flaky, crashing test in Windows #45786

TST: Skip flaky, crashing test in Windows #45786

Conversation

mroeschke commented Feb 2, 2022

jbrockmendel Feb 3, 2022

Choose a reason for hiding this comment

jreback Feb 3, 2022

Choose a reason for hiding this comment

mroeschke Feb 3, 2022

Choose a reason for hiding this comment

jreback commented Feb 3, 2022

mroeschke commented Feb 3, 2022

lumberbot-app bot commented Feb 3, 2022