Skip to content

TST: Ensure tm.network has pytest.mark.network #45732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2022
Merged

TST: Ensure tm.network has pytest.mark.network #45732

merged 2 commits into from
Jan 31, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Jan 31, 2022 •
edited
Loading

  • Ensure tm.network is paired with @pytest.mark.network
  • Refactored test (by downloading data directly) that is not testing networking specifically

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite IO Network Local or Cloud (AWS, GCS, etc.) IO Issues labels Jan 31, 2022
@jreback jreback added this to the 1.4.1 milestone Jan 31, 2022
@jreback
Copy link
Contributor

jreback commented Jan 31, 2022

hmm there is an included teams.cvs is that intentional?

@mroeschke
Copy link
Member Author

hmm there is an included teams.cvs is that intentional?

Yes this is expected. It was the test I referenced as "Refactored test (by downloading data directly) that is not testing networking specifically"

@jreback jreback merged commit 2dd75ca into pandas-dev:main Jan 31, 2022
@jreback
Copy link
Contributor

jreback commented Jan 31, 2022

@meeseeksdev backport 1.4.x

@lumberbot-app

This comment has been minimized.

Sign in to view
@lumberbot-app

This comment has been minimized.

Sign in to view
@mroeschke mroeschke deleted the tst/network_refactor branch January 31, 2022 17:28
mroeschke added a commit to mroeschke/pandas that referenced this pull request Jan 31, 2022
@mroeschke
Backport PR pandas-dev#45732: TST: Ensure tm.network has pytest.mark.…
a522c16 
…network
jreback pushed a commit that referenced this pull request Jan 31, 2022
@mroeschke
Backport PR #45732: TST: Ensure tm.network has pytest.mark.network (#…
db131b6 
…45741)
@simonjayhawkins simonjayhawkins mentioned this pull request Feb 1, 2022
Merged
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 14, 2022
@mroeschke @phofl
TST: Ensure tm.network has pytest.mark.network (pandas-dev#45732)
d62c85d
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@mroeschke @yehoshuadimarsky
TST: Ensure tm.network has pytest.mark.network (pandas-dev#45732)
8abd851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO Network Local or Cloud (AWS, GCS, etc.) IO Issues Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

BUG: test_wrong_url tests should be skipped with "--skip-network"
3 participants
@mroeschke @jreback @simonjayhawkins