Skip to content

BUG: test_wrong_url tests should be skipped with "--skip-network" #45085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 3 tasks
Apteryks opened this issue Dec 28, 2021 · 0 comments · Fixed by #45732
Closed
2 of 3 tasks

BUG: test_wrong_url tests should be skipped with "--skip-network" #45085

Apteryks opened this issue Dec 28, 2021 · 0 comments · Fixed by #45732
Labels
Bug Testing pandas testing functions or related to the test suite
Milestone

Comments

@Apteryks
Copy link

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the master branch of pandas.

Reproducible Example

In a container which doesn't have networking facilities, run the test suite with:

pytest" -vv pandas --skip-slow --skip-network

Observe that the following tests fail:

pandas/tests/io/xml/test_xml.py::test_wrong_url[lxml]
pandas/tests/io/xml/test_xml.py::test_wrong_url[etree]


### Issue Description

The test_wrong_url apparently need to have network access, but aren't skipped by --skip-network.

### Expected Behavior

Given --skip-network was provided, the pandas/tests/io/xml/test_xml.py::test_wrong_url[lxml] and pandas/tests/io/xml/test_xml.py::test_wrong_url[etree] tests should have been skipped.

### Installed Versions

1.3.5
@Apteryks Apteryks added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 28, 2021
@mroeschke mroeschke added Testing pandas testing functions or related to the test suite and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 28, 2021
@jreback jreback added this to the 1.4.1 milestone Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants