BUG: Fix Segfault with pd.tslib.get_period_field (GH4519, GH4520) #4562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,6 +116,8 @@ pandas 0.13 | |||
|
|
|||
| - ``HDFStore`` | |||
|
|
|||
| - ``tslib.get_period_field()`` and ``tslib.get_period_field_arr()`` now raise | |||
| if code argument out of range (:issue:`4519`, :issue:`4520`) | |||
There was a problem hiding this comment.
pls move this to the end of the Bugs section (as the last entry)
|
Indeed, that would work but it seems to be simpler and cheaper to check f against NULL rather than using Cython's exception specification machinery. |
|
its fine...just pointing out another way...pls rebase and squash commits into 1 and i'll merge you in |
|
Done! Thanks. |
jreback
added a commit
that referenced
this pull request
Aug 15, 2013
BUG: Fix Segfault with pd.tslib.get_period_field (GH4519, GH4520)
|
@prossahl thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following problem (issues #4519, #4520):