-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Segfault with pd.tslib.get_period_field FIX #4520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@prossahl |
do
and delete the first 2 commits; this makes this branch independent |
@@ -0,0 +1,18 @@ | |||
import unittest | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't put this in a separate file, stick in tests/test_tseries.py
Abandoned. I'll resubmit this. |
@prossahl should this be closed then? |
@cpcloud Well without the change the segfault can still happen. I'll submit a new pull request as this one pulled in irrelevant changes. |
you don't need to do that. do this git reset HEAD~1
git stash
git fetch upstream
git reset --hard upstream/master
git stash pop
git commit -am'Your awesome commit message'
git push --force |
Thanks v. much for your help but its a no go. |
check out this wiki page: https://github.com/pydata/pandas/wiki/Using-Git and also pls read this: https://github.com/pydata/pandas/blob/master/CONTRIBUTING.md |
closes #4519