Skip to content

test replace on out of bound datetime #45525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2022
Merged

test replace on out of bound datetime #45525

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db788f7
test replace on out of bound datetime
Jan 21, 2022
e4ad47f
Remove uneeded comments
Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pandas/tests/frame/methods/test_replace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,6 +753,13 @@ def test_replace_for_new_dtypes(self, datetime_frame):
"bar",
DataFrame({"dt": [datetime(3017, 12, 20)], "str": ["bar"]}),
),
# GH 36782
(
DataFrame({"dt": [datetime(2920, 10, 1)]}),
datetime(2920, 10, 1), # out of range date
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the comments in this line and the following line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay - thanks for the feedback. I'll make the change.

Is it best practice to leave out comments like this? Is the GH reference enough?

Do you know why the build check failed? Looks like it timed out, is there anything I should do to prevent this?

datetime(2020, 10, 1), # in range date
DataFrame({"dt": [datetime(2020, 10, 1)]}),
),
(
DataFrame(
{
Expand Down