test replace on out of bound datetime #45525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Jan 21, 2022
| # GH 36782 | ||
| ( | ||
| DataFrame({"dt": [datetime(2920, 10, 1)]}), | ||
| datetime(2920, 10, 1), # out of range date |
There was a problem hiding this comment.
You can remove the comments in this line and the following line
There was a problem hiding this comment.
Okay - thanks for the feedback. I'll make the change.
Is it best practice to leave out comments like this? Is the GH reference enough?
Do you know why the build check failed? Looks like it timed out, is there anything I should do to prevent this?
jreback
added
replace
mroeschke
approved these changes
Jan 22, 2022
|
thanks @ryangilmour |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adds a test for the functionality that is working on
main. Placed the test in amongst the otherDataFrame.replacetests.