Skip to content

DEPR: DatetimeIndex.intersection with mixed timezones cast to UTC, not object #45357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 17, 2022
Merged

DEPR: DatetimeIndex.intersection with mixed timezones cast to UTC, not object #45357

merged 5 commits into from
Jan 17, 2022

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jan 14, 2022 •
edited
Loading

This matches the union behavior, which we deprecated in 1.3.0

(closing #24362 is pretty subjective, but i think this is the best we can do)

jorisvandenbossche
jorisvandenbossche approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jorisvandenbossche jorisvandenbossche added setops union, intersection, difference, symmetric_difference Timezones Timezone data dtype Deprecate Functionality to remove in pandas labels Jan 14, 2022
@jorisvandenbossche jorisvandenbossche added this to the 1.5 milestone Jan 14, 2022
@jreback jreback mentioned this pull request Jan 16, 2022
Closed
@jreback
Copy link
Contributor

jreback commented Jan 16, 2022

lgtm can merge on green

@jbrockmendel jbrockmendel merged commit 4e034ec into pandas-dev:main Jan 17, 2022
@jbrockmendel jbrockmendel deleted the depr-setops-utc branch January 17, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas setops union, intersection, difference, symmetric_difference Timezones Timezone data dtype
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

tz-aware DatetimeIndex intersection raises AttributeError when values are the same but tz differs
3 participants
@jbrockmendel @jreback @jorisvandenbossche