Skip to content

TST: Split/parameterize indexing tests #45325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 13, 2022
Merged

TST: Split/parameterize indexing tests #45325

merged 5 commits into from
Jan 13, 2022

Conversation

mroeschke
Copy link
Member

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Indexing Related to indexing on series/frames, not to indexes themselves and removed Indexing Related to indexing on series/frames, not to indexes themselves labels Jan 12, 2022
jbrockmendel
jbrockmendel reviewed Jan 12, 2022
View reviewed changes
pandas/tests/indexing/test_loc.py
[20, ["floats"], 0],
],
)
def test_loc_getitem_label_out_of_range(self, key, typs, axes):

# out of range label
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this comment apply to all of these or just the one currently on L60?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment applies to all cases.

@mroeschke mroeschke added this to the 1.5 milestone Jan 12, 2022
@jreback jreback merged commit 2026854 into pandas-dev:main Jan 13, 2022
@mroeschke mroeschke deleted the tst/param_index branch January 13, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @jbrockmendel @jreback