Skip to content

API/DEPR: reintroduce errors kwd in where, mask, deprecate inconsistent behaviors #45193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

xref #45190 which does the same thing for fillna

Lots of new code here, but most of it goes away once deprecations are enforced.

Many new paths here don't have test coverage.

Existing docstring says we accept "ignore", "raise", while this PR assumes "raise" and "coerce". So this would need to be updated/deprecated.

@jbrockmendel jbrockmendel marked this pull request as draft January 6, 2022 02:29
@jbrockmendel jbrockmendel added the API - Consistency Internal Consistency of API/Behavior label Jan 6, 2022
@jreback
Copy link
Contributor

jreback commented Jan 8, 2022

I like this as along with the .fillna and hopefully .astype changes we get to a consistent place. this would be ok for 1.4 (as this is reversing a current deprecation).

@jbrockmendel
Copy link
Member Author

hopefully .astype changes

AFAIK that's not on the horizon

@jbrockmendel
Copy link
Member Author

this would be ok for 1.4 (as this is reversing a current deprecation).

i think we should reverse the current deprecation in 1.4 and do this (with appropriate tests) for 1.5

@jreback
Copy link
Contributor

jreback commented Jan 8, 2022

cool, pls rebase

@jbrockmendel jbrockmendel modified the milestones: 1.4, 1.5 Jan 12, 2022
@jbrockmendel
Copy link
Member Author

Mothballing while I try to sort out some of the kinks (and to clear the queue)

@jbrockmendel jbrockmendel added the Mothballed Temporarily-closed PR the author plans to return to label Jan 13, 2022
@jbrockmendel jbrockmendel deleted the where-errors branch November 28, 2022 20:05
@jbrockmendel jbrockmendel removed the Mothballed Temporarily-closed PR the author plans to return to label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API - Consistency Internal Consistency of API/Behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants