POC/API/DEPR: errors kwd for fillna #45190
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #45153
Upsides: 1) users get to control the behavior, 2) we can deprecate the inconsistent default behaviors to become consistent
Downsides: 1) Larger API surface area, 2) many more test cases to cover (which ATM this PR does none of), 3) increased code complexity, though most of that goes away once deprecations are enforced.
Could implement the same for Index.fillna to keep it consistent.
If we go down this road, I'd want to do the same for other sometimes-casting methods: putmask, where, replace. (which just leaves
__setitem__
is inconsistent)