TST: fixturize, collect #44242
TST: fixturize, collect #44242
Conversation
jbrockmendel
commented
Oct 30, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
pandas/conftest.py
Outdated
| @@ -921,6 +921,23 @@ def all_binary_operators(request): | |||
| return request.param | |||
|
|
|||
|
|
|||
| @pytest.fixture( | |||
There was a problem hiding this comment.
isn't this all_compare_operators in this file ?
There was a problem hiding this comment.
we don't really distinguish the naming here. e.g. for arithmetic we have
all_binary_operations (using operator) and all_arithmetic_operators.
so ideally have some good pattern here.
maybe
all_comparison_operators (use operator)
all_comparison_dunder (use dunder)
would have to fix a bunch of things but prob worth it.
There was a problem hiding this comment.
yah not something i want to futz with
There was a problem hiding this comment.
sure but we cannot add it like this, so need to do something. e.g. move next to the others & rename this one to conform.
There was a problem hiding this comment.
will move this down adjacent to all_compare_operators
There was a problem hiding this comment.
looks like most of the places here we use the dunder one then do a getattr(operator, all_comparison_operators.strip("__")), so will just replace those usages with this
|
That’s the dunder strings
…On Sat, Oct 30, 2021 at 4:57 PM Jeff Reback ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pandas/conftest.py
<#44242 (comment)>:
> @@ -921,6 +921,23 @@ def all_binary_operators(request):
return request.param
***@***.***(
isn't this all_compare_operators( ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#44242 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5UM6HZOBOP7JW4FAELPJLUJSA6BANCNFSM5HBTEHYQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
| @pytest.mark.parametrize("box", [pd.Series, pd.DataFrame]) | ||
| def test_direct_arith_with_ndframe_returns_not_implemented(self, data, box): | ||
| def test_direct_arith_with_ndframe_returns_not_implemented( | ||
| self, data, frame_or_series |
There was a problem hiding this comment.
