Skip to content

TST: tests using invalid_scalar fixture #44175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 30, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added this to the 1.4 milestone Oct 25, 2021
@jreback jreback added Error Reporting Incorrect or improved errors from pandas ExtensionArray Extending pandas with custom dtypes or arrays. labels Oct 25, 2021
@jreback
Copy link
Contributor

jreback commented Oct 25, 2021

this could be a new user facing message right, can you add a whatsnew note

@jbrockmendel
Copy link
Member Author

this could be a new user facing message right, can you add a whatsnew note

not exactly; pretty hard to reach from Series/DataFrame methods

@jreback
Copy link
Contributor

jreback commented Oct 28, 2021

can you rebase

@jreback
Copy link
Contributor

jreback commented Oct 29, 2021

@jreback jreback merged commit f1286a7 into pandas-dev:master Oct 30, 2021
@jbrockmendel jbrockmendel deleted the tst-invalid_scalar branch October 31, 2021 01:18
"index out of bounds", # pyarrow
"Out of bounds access", # Sparse
f"index {ub+1} is out of bounds for axis 0 with size {ub}",
f"index -{ub+1} is out of bounds for axis 0 with size {ub}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  with pytest.raises(IndexError, match=msg):

E AssertionError: Regex pattern 'list index out of range|index out of bounds|Out of bounds access|index 101 is out of bounds for axis 0 with size 100|index -101 is out of bounds for axis 0 with size 100' does not match 'loc must be an integer between -100 and 100'.

i think these are asserting on 3.10 builds

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be addressed by just-pushed commit in #44242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants