Skip to content

CI: Fix mypy failures #44144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 22, 2021
Merged

CI: Fix mypy failures #44144

merged 4 commits into from
Oct 22, 2021

Conversation

alimcmaster1
Copy link
Member

@alimcmaster1 alimcmaster1 added this to the 1.3.5 milestone Oct 22, 2021
simonjayhawkins
simonjayhawkins approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alimcmaster1 merge on green

@simonjayhawkins simonjayhawkins added CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions Typing type annotations, mypy/pyright type checking labels Oct 22, 2021
@alimcmaster1
Copy link
Member Author

Thanks @alimcmaster1 merge on green

ty - will do! Thanks for the prompt review!

@twoertwein
Copy link
Member

Shouldn't the type (of the input and output) be changed to np.ndarray as the dtype might change?

@jbrockmendel
Copy link
Member

LGTM

@twoertwein twoertwein mentioned this pull request Oct 22, 2021
Merged
4 tasks
@alimcmaster1
Copy link
Member Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@alimcmaster1 alimcmaster1 merged commit d1ee9ff into pandas-dev:master Oct 22, 2021
@meeseeksmachine meeseeksmachine mentioned this pull request Oct 22, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Oct 22, 2021
@alimcmaster1 @meeseeksmachine
Backport PR pandas-dev#44144: CI: Fix mypy failures
57060f7
alimcmaster1 added a commit that referenced this pull request Oct 22, 2021
@meeseeksmachine @alimcmaster1
Backport PR #44144: CI: Fix mypy failures (#44149)
b66c366 
Co-authored-by: Ali McMaster <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins requested changes

Assignees
No one assigned
Labels
CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.3.5
Development

Successfully merging this pull request may close these issues.

CI: mypy failures
4 participants
@alimcmaster1 @twoertwein @jbrockmendel @simonjayhawkins