Skip to content

CI: mypy failures #44143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alimcmaster1 opened this issue Oct 22, 2021 · 2 comments · Fixed by #44144
Closed

CI: mypy failures #44143

alimcmaster1 opened this issue Oct 22, 2021 · 2 comments · Fixed by #44144
Labels
CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions Typing type annotations, mypy/pyright type checking
Milestone
1.3.5

Comments

@alimcmaster1
Copy link
Member

Seeing this in multiple builds:

https://github.com/pandas-dev/pandas/runs/3972068892?check_suite_focus=true

mypy --version
mypy 0.910
Performing static analysis using mypy
pandas/core/dtypes/cast.py:913: error: Incompatible types in assignment (expression has type "ndarray[Any, dtype[Any]]", variable has type "NumpyArrayT")  [assignment]
pandas/tests/indexes/test_engines.py:65: error: unused "type: ignore" comment

Taking a look now
@alimcmaster1 alimcmaster1 added the CI Continuous Integration label Oct 22, 2021
@simonjayhawkins
Copy link
Member

Taking a look now

presumably we a picking up the new release of numpy 1.21.3 on ci now?

mypy failures on a new release of numpy are not unexpected. can just add "fix later" ignores on new errors and remove unused "type: ignore" to get ci to green for now.

@alimcmaster1 alimcmaster1 mentioned this issue Oct 22, 2021
Merged
1 task
@simonjayhawkins simonjayhawkins added Compat pandas objects compatability with Numpy or Python functions Typing type annotations, mypy/pyright type checking labels Oct 22, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3.5 milestone Oct 22, 2021
@simonjayhawkins
Copy link
Member

adding 1.3.5 milestone as we will probably need to backport also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration Compat pandas objects compatability with Numpy or Python functions Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.3.5
Development

Successfully merging a pull request may close this issue.

CI: Fix mypy failures alimcmaster1/pandas
2 participants
@simonjayhawkins @alimcmaster1