Skip to content

BUG: to_datetime with xarray DataArray and specifie unit errors #44074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 19, 2021

Conversation

rocabrera
Copy link
Contributor

Let me know if any change need to be done. Let me know if you need to make any changes.
I love the package hope I can start helping more :)

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also add a whatsnew note (bug fixes conversion for 1.4)

@jreback jreback added this to the 1.4 milestone Oct 18, 2021
@jreback jreback added Bug Dtype Conversions Unexpected or buggy dtype conversions labels Oct 18, 2021
@jreback jreback changed the title BUG coerce to numpy array BUG: to_datetime with xarray DataArray and specifie unit errors Oct 18, 2021
@pep8speaks
Copy link

pep8speaks commented Oct 18, 2021

Hello @rocabrera! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-10-18 23:38:45 UTC

@rocabrera
Copy link
Contributor Author

I will add a note tomorrow !
#44074 (review)

@rocabrera rocabrera requested a review from jreback October 18, 2021 13:44
@jreback jreback merged commit 3a6d4cd into pandas-dev:master Oct 19, 2021
@jreback
Copy link
Contributor

jreback commented Oct 19, 2021

thanks @rocabrera

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: to_datetime with xarray DataArray and specifie unit errors
3 participants