BUG: to_datetime with xarray DataArray and specifie unit errors #44073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @shubham11941140! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-10-17 19:46:06 UTC |
jreback
requested changes
Oct 17, 2021
| @@ -525,7 +525,13 @@ def _to_datetime_with_unit(arg, unit, name, tz, errors: str) -> Index: | |||
| arr = arg.astype(f"datetime64[{unit}]") | |||
| tz_parsed = None | |||
| else: | |||
| arr, tz_parsed = tslib.array_with_unit_to_datetime(arg, unit, errors=errors) | |||
| import xarray | |||
There was a problem hiding this comment.
pls don't import xarray like this
it's not a dependency
There was a problem hiding this comment.
How do I do it? Should I write it on top?
| @@ -2650,3 +2650,15 @@ def test_to_datetime_monotonic_increasing_index(cache): | |||
| result = to_datetime(times.iloc[:, 0], cache=cache) | |||
| expected = times.iloc[:, 0] | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
| def test_xarray_DataArray(): | |||
There was a problem hiding this comment.
you will need to skip if xarray is not installed
|
closing in favor of #44074 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted values of xarray.DataArray to numpy.ndarray to solve the problem.