CLN: share rank_t fused type #43789
Merged
CLN: share rank_t fused type #43789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeitlin11
added
Internals
jreback
reviewed
Sep 28, 2021
pandas/_libs/dtypes.pxd
Outdated
| uint64_t, | ||
| ) | ||
|
|
||
| ctypedef fused rank_t: |
There was a problem hiding this comment.
can we give this a descriptive name, maybe numeric_object_t or similiar? (of course can update these later too which is fine)
There was a problem hiding this comment.
sounds like a good starting point, have updated
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small step towards #43774