Skip to content

CLN: unify fused type definitions #43774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Sep 27, 2021 · 4 comments
Closed

CLN: unify fused type definitions #43774

jreback opened this issue Sep 27, 2021 · 4 comments
Labels
API - Consistency Internal Consistency of API/Behavior Clean Closing Candidate May be closeable, needs more eyeballs Internals Related to non-user accessible pandas implementation

Comments

@jreback
Copy link
Contributor

jreback commented Sep 27, 2021

grep -r fused pandas/_libs/ --include '*.pyx'
pandas/_libs/writers.pyx:ctypedef fused pandas_string:
pandas/_libs/reshape.pyx:ctypedef fused reshape_t:
pandas/_libs/join.pyx:ctypedef fused join_t:
pandas/_libs/join.pyx:ctypedef fused asof_t:
pandas/_libs/join.pyx:ctypedef fused by_t:
pandas/_libs/algos.pyx:ctypedef fused algos_t:
pandas/_libs/algos.pyx:ctypedef fused rank_t:
pandas/_libs/algos.pyx:ctypedef fused diff_t:
pandas/_libs/algos.pyx:ctypedef fused out_t:
pandas/_libs/groupby.pyx:ctypedef fused add_t:
pandas/_libs/groupby.pyx:ctypedef fused rank_t:
pandas/_libs/groupby.pyx:ctypedef fused groupby_t:

cc @mzeitlin11 @jbrockmendel

@jreback jreback added Internals Related to non-user accessible pandas implementation Clean API - Consistency Internal Consistency of API/Behavior labels Sep 27, 2021
@jreback jreback added this to the Contributions Welcome milestone Sep 27, 2021
@jreback
Copy link
Contributor Author

jreback commented Sep 27, 2021

maybe we need a dtypes.pyx that is shared

@mzeitlin11
Copy link
Member

There's also the cython builtins numeric and floating we use in a few places.

It would be nice for many of these to just use numeric instead (maybe with object added in some cases) - there's a tradeoff between adding more fused types (which can improve performance by avoiding upcasting for a case like #42275), but at the cost of each new fused type increasing library size.

@jbrockmendel
Copy link
Member

closeable?

@jbrockmendel jbrockmendel added the Closing Candidate May be closeable, needs more eyeballs label Apr 22, 2022
@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
@mroeschke
Copy link
Member

I think we've consolidate a lot of fused types recently so closing. We can open specific issues for types can that be more fused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API - Consistency Internal Consistency of API/Behavior Clean Closing Candidate May be closeable, needs more eyeballs Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

No branches or pull requests

4 participants