BUG: groupby mean fails for complex #43756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
debnathshoham
commented
Sep 26, 2021
debnathshoham
commented
- closes BUG: Can't compute group mean of complex values #43701
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
mzeitlin11
reviewed
Sep 27, 2021
3 tasks
mzeitlin11
reviewed
Sep 28, 2021
mzeitlin11
approved these changes
Sep 28, 2021
jreback
requested changes
Sep 29, 2021
|
|
||
|
|
||
| def test_groupby_mean_complex(): | ||
| # GH#43701 |
There was a problem hiding this comment.
can parmaetirze this test instead. also can you add the failing ones in another test, eg.. test_groupby_op_complex_error (e.g. min, max, etc, e.g the non-working ones)
jreback
approved these changes
Sep 30, 2021
|
thanks @debnathshoham @mzeitlin11 happy to have more consolidation of fused types |
gasparitiago
pushed a commit
to gasparitiago/pandas
that referenced
this pull request
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.