Skip to content

World Bank I/O docs and minimal improvement #4364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2013
Merged

World Bank I/O docs and minimal improvement #4364

merged 1 commit into from
Jul 25, 2013

Conversation

vincentarelbundock
Copy link

  • DOC: Simple example of how to use Pandas' World Bank IO functions.
  • ENH: Return a DataFrame full of floats instead of full of strings

RE: #4354

@vincentarelbundock
Copy link
Author

@vincentarelbundock
Copy link
Author

Cool. I rebased/fixuped for cleaner history. Now using convert_objects

@jreback
Copy link
Contributor

jreback commented Jul 25, 2013

looks good...do you have travis enabled?

@vincentarelbundock
Copy link
Author

I didn't, but now I flipped the switch and made a minor push. I dont' have a lot of experience with travis, so I don't know if this will work.

@jreback
Copy link
Contributor

jreback commented Jul 25, 2013

git ci --amend -C HEAD will basically repush the last commit with a new hash, but what you did was fine.....

@jreback
Copy link
Contributor

jreback commented Jul 25, 2013

can you rebase to 1 commit? otherwise seems ready to go

@vincentarelbundock
Copy link
Author

done

@jreback
Copy link
Contributor

jreback commented Jul 25, 2013

going to merge in a few.....

side issue

should these types of Data I/O things (which are really remote data readers) as opposed to local data formats
be put in a separate doc section entirely?

maybe Data Readers?

@cpcloud ?

@cpcloud
Copy link
Member

cpcloud commented Jul 25, 2013

That sounds good, what about "Remote Data Access"?

@jreback
Copy link
Contributor

jreback commented Jul 25, 2013

sure.....will throw it in....

@jreback jreback merged commit 9209224 into pandas-dev:master Jul 25, 2013
@vincentarelbundock
Copy link
Author

@jreback the code chunks don't show up in the live docs: http://pandas.pydata.org/pandas-docs/dev/remote_data.html

What did I do wrong?

@jreback
Copy link
Contributor

jreback commented Jul 26, 2013

your directives were code, while we use code-block in the rest of the code. must be a older version of sphinx that wesm builds with; I built locally and worked fine. i just changed them and it worked fine. weird.

fixed here: 19c8874

give a once onver after 5pm est again...thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants