-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Backport PR #43608: REGR: spearman corr raising on 32-bit #43614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport PR #43608: REGR: spearman corr raising on 32-bit #43614
Conversation
cc @lithomas1 does the circleci pr need to be backported? |
On it, thanks for the reminder. This was not backported initially because we wanted to see if it worked first. This might still fail if 1.3.x doesn't work well with ARM64 but we'll see. |
@mzeitlin11 if you'd merge 1.3.x master and push again (to pick up the circle config) |
thanks @mzeitlin11 |
@mzeitlin11 when doing the manual backport , we need to make sure that the merge conflicts in the release notes are resolved in the same order as master otherwise future autobackports could fail. I'll do a PR syncing the notes on 1.3.x with master shortly. There is also a missing double quote in the release note. if this is fixed on master, the autobackport will fail until the notes are synced. I'll do that after since there is also an error in the release note for #43132 which can be done at the same time. |
will merge #43630 first, but restated ci on that one to get to green. |
Sorry about messing that up, will keep in mind going forward. Please let me know if there's anything I can do to help |
no problem. easy to do and easy to fix #43636 |
Backport PR #43608