Skip to content

Backport PR #43608: REGR: spearman corr raising on 32-bit #43614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 17, 2021

Conversation

mzeitlin11
Copy link
Member

@mzeitlin11 mzeitlin11 commented Sep 16, 2021

Backport PR #43608

@mzeitlin11 mzeitlin11 added Regression Functionality that used to work in a prior pandas version Numeric Operations Arithmetic, Comparison, and Logical operations Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff labels Sep 16, 2021
@mzeitlin11 mzeitlin11 added this to the 1.3.4 milestone Sep 16, 2021
@mzeitlin11
Copy link
Member Author

cc @lithomas1 does the circleci pr need to be backported?

@lithomas1
Copy link
Member

On it, thanks for the reminder. This was not backported initially because we wanted to see if it worked first. This might still fail if 1.3.x doesn't work well with ARM64 but we'll see.

@jreback
Copy link
Contributor

jreback commented Sep 17, 2021

@mzeitlin11 if you'd merge 1.3.x master and push again (to pick up the circle config)

@jreback jreback merged commit 863559a into pandas-dev:1.3.x Sep 17, 2021
@jreback
Copy link
Contributor

jreback commented Sep 17, 2021

thanks @mzeitlin11

@mzeitlin11 mzeitlin11 deleted the backport-of-pr-43608-on-1.3.x branch September 17, 2021 16:53
@simonjayhawkins
Copy link
Member

@mzeitlin11 when doing the manual backport , we need to make sure that the merge conflicts in the release notes are resolved in the same order as master otherwise future autobackports could fail.

I'll do a PR syncing the notes on 1.3.x with master shortly.


There is also a missing double quote in the release note. if this is fixed on master, the autobackport will fail until the notes are synced. I'll do that after since there is also an error in the release note for #43132 which can be done at the same time.

@simonjayhawkins
Copy link
Member

I'll do a PR syncing the notes on 1.3.x with master shortly.

will merge #43630 first, but restated ci on that one to get to green.

@mzeitlin11
Copy link
Member Author

@mzeitlin11 when doing the manual backport , we need to make sure that the merge conflicts in the release notes are resolved in the same order as master otherwise future autobackports could fail.

Sorry about messing that up, will keep in mind going forward. Please let me know if there's anything I can do to help

@simonjayhawkins
Copy link
Member

Sorry about messing that up

no problem. easy to do and easy to fix #43636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Numeric Operations Arithmetic, Comparison, and Logical operations Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants