REGR: spearman corr raising on 32-bit #43608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeitlin11
added
32bit
ok @mzeitlin11 merge then fixup the backport right? |
Yep! |
This comment has been minimized.
This comment has been minimized.
|
@meeseeksdev backport 1.3.x |
This comment has been minimized.
This comment has been minimized.
mzeitlin11
added a commit
to mzeitlin11/pandas
that referenced
this pull request
Sep 16, 2021
jreback
pushed a commit
that referenced
this pull request
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works on master, so this PR just adds a regression test (by removing the unnecessary
scipyskips, this should be ensuring that somespearmantests will be run on 32-bit).In the backport, these tests with the skip removed should fail, but the fix should be tiny (replacing 2
int64withintp)