Backport fastparquet 0.7 compat (PR #42954 and #42919) #42987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What? How is CI picking up fastparquet 0.7.0. This needs more investigation... |
simonjayhawkins
added
Compat
|
Anyone on the core team want to restart just the database builds? I just want to confirm that this is not flaky. |
| # Still need to ensure that this raises in all versions below | ||
| import fastparquet as fp | ||
|
|
||
| monkeypatch.setattr(fp, "__version__", "0.4") |
There was a problem hiding this comment.
This monkeypatch actually shouldn't be needed?
There was a problem hiding this comment.
Yep, forgot to revert this part. It's actually present in master too. Will do after this, so the bot can auto backport.
|
Restarted, but it was indeed installing fastparquet 0.7.0 ... |
|
Ok figured it out. fastparquet decided to actually enforce numpy>1.18 in 0.7.1. |
jorisvandenbossche
changed the title
|
Thanks! (and indeed, a follow-up PR for my comment is the easiest ;)) |
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-trivial backport. Please first review changed files before merging. Thanks