-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
COMPAT: Support fastparquet 0.7.1 #42919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
parquet_kwargs["pandas_nulls"] = use_nullable_dtypes | ||
else: | ||
if use_nullable_dtypes: | ||
raise ValueError( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this path tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @lithomas1 |
@meeseeksdev backport 1.3.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
As I mentioned (lately) on the issue, I am not in favor of enabling the |
hmm, we have the change note in 1.3.2 whatsnew. can we revert this from master, reopen the PR to continue the discussion. and have two separate PRs if needed to avoid a partial backport. |
Happy to talk it out. I think we can backport something that just turns of all the nullable dtypes for now until we get this sorted out. Will send PR soon. |
Also adds support for
use_nullable_dtypes
keyword. Technically, its not our enhancement its fastparquet's, so I think can backport. IMO, users shouldn't have to wait 6 months for 1.4 to get this new feature.