CI: Add ASV Bot #42911
Merged
CI: Add ASV Bot #42911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CI: ASV Bot * Rename main.yml to asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Remove debug stuff
|
can u require a regex to target only matching benchmarks? would make it way faster |
|
most PRs would be OK with |
|
@lithomas1 happy to merge this and can PR again to update, lmk. (ideally would like the selective benchmarks though) |
|
Looking to get some more changes in. This may take a while though. |
* remove debug statement * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml * Update asv-bot.yml
|
Got the regexes working. e.g. lithomas1#7 (comment) Unfortunately doesn't work with -b (?!libs) right now. I guess it doesn't like the backslash. I think I'll try to get this to work in a follow up. This PR is already getting large. |
|
thanks @lithomas1 |
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggers with command
@github-actions benchmark -b ^regexgoeshere(doesn't work rn, needs to be merged to work, this is an example result though, lithomas1#6 (comment), which is me testing it on the io.csv benchmarks). Our benchmarks are super slow right now, they take six hours to do, so having this bot might help for people with weaker computers. Unfortunately, this also can clog up our CI pipelines, so I added a concurrency limit, which restricts runs to 1 per person.cc @jbrockmendel @simonjayhawkins